pingsutw commented on code in PR #10849:
URL: https://github.com/apache/datafusion/pull/10849#discussion_r1636889529
##########
datafusion/core/src/execution/session_state.rs:
##########
@@ -387,9 +387,9 @@ impl SessionState {
/// Add `analyzer_rule` to the end of the list of
/// [`AnalyzerRule`]s used to rewrite queries.
pub fn add_analyzer_rule(
- mut self,
+ &mut self,
Review Comment:
Should we also update `add_optimizer_rule` `add_physical_optimizer_rule`?
(mut self -> &mut self)
Also, do we need to add `with_optimizer_rule` and
`with_physical_optimizer_rule` to make it consistent?
If so, I can do it in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
