alamb commented on code in PR #10849: URL: https://github.com/apache/datafusion/pull/10849#discussion_r1638488162
########## datafusion/core/tests/user_defined/user_defined_plan.rs: ########## @@ -619,3 +627,49 @@ impl RecordBatchStream for TopKReader { self.input.schema() } } + +struct MyAnalyzerRule {} Review Comment: Would it be possible to add test that exercises these APIs? For example, perhaps a test that does something like ```sql select 42, arrow_typeof(42) ``` Which I think this code will print out 42 and `UInt`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org