MohamedAbdeen21 commented on PR #10868: URL: https://github.com/apache/datafusion/pull/10868#issuecomment-2166538137
The failing CI is a simple `clippy` warning, I'd appreciate if it can be fixed before merging. The last thread between me and @peter-toth mentions some possible improvements, but these should be a separate follow-up PR. I'm extremely sorry for not being able to push any further changes. And thanks @peter-toth for partaking in this long, boring review process and helping me understand this rule better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org