peter-toth commented on PR #10868: URL: https://github.com/apache/datafusion/pull/10868#issuecomment-2169716461
> The failing CI is a simple `clippy` warning, I'd appreciate if it can be fixed before merging. > > The last thread between me and @peter-toth mentions some possible improvements, but these should be a separate follow-up PR. > > I'm extremely sorry for not being able to push any further changes. And thanks @peter-toth for partaking in this long, boring review process and helping me understand this rule better. Thanks @MohamedAbdeen21 for the PR! I fixed the clippy issue and made some changes to alias generation as it turned out that there is an `AliasGenerator` available for optimizer rules. I also reverted some unnecessary changes. https://github.com/peter-toth/arrow-datafusion/commits/cse-numeric-aliases/ contains your original commits, a merge commit from `main` and my suggestions in the last commit. As far as I see we have 2 options: - I can open a PR targeting this PR and then you can review my suggestions and merge them into this PR. - Or I can open a new PR targeting `main` which will contain your commits too. cc @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
