alamb commented on code in PR #10908:
URL: https://github.com/apache/datafusion/pull/10908#discussion_r1639090072
##########
datafusion/functions-array/src/string.rs:
##########
@@ -281,6 +281,21 @@ pub(super) fn array_to_string_inner(args: &[ArrayRef]) ->
Result<ArrayRef> {
Ok(arg)
}
+ Dictionary(..) => {
+ let any_dict_array = arr.as_any_dictionary_opt().ok_or_else(
|| {
+ DataFusionError::Internal(
+ format!("could not cast {} to AnyDictionaryArray",
arr.data_type())
+ )
+ })?;
+ compute_array_to_string(
Review Comment:
I think this code may just return the dictionary converted to string,
https://docs.rs/arrow/latest/arrow/array/struct.DictionaryArray.html
You might have to expand out the values again (perhaps cast the result to
`DataType::Utf8` 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
