alamb commented on code in PR #10908:
URL: https://github.com/apache/datafusion/pull/10908#discussion_r1643081498
##########
datafusion/functions-array/src/string.rs:
##########
@@ -281,6 +281,24 @@ pub(super) fn array_to_string_inner(args: &[ArrayRef]) ->
Result<ArrayRef> {
Ok(arg)
}
+ Dictionary(..) => {
+ let any_dict_array = arr
+ .as_any_dictionary_opt()
+ .ok_or_else( || {
+ DataFusionError::Internal(
+ format!("could not cast {} to AnyDictionaryArray",
arr.data_type())
+ )
+ })?;
+ compute_array_to_string(
Review Comment:
I pushed some tests showing how this results in incorrect values.
I think you may be able to call `to_string!` directly to iterate over the
values of the dictionary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
