jayzhan211 commented on PR #10917: URL: https://github.com/apache/datafusion/pull/10917#issuecomment-2170996403
> Yes, it will be correct for the logical plan. However, I think it will cause some issues when processing the physical plan. Curiously, should we expect the physical roundtrip to work? I tried to add a roundtrip test for it in`datafusion/proto/tests/cases/roundtrip_physical_plan.rs` like: I have an idea of moving the accumulator and state_fields computation up to create_aggregate_expr, so we don't need to pass logical expression downward to AggregateFunctionExpr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
