jayzhan211 commented on code in PR #10917:
URL: https://github.com/apache/datafusion/pull/10917#discussion_r1641592218
##########
datafusion/functions-aggregate/src/approx_percentile_cont_with_weight.rs:
##########
@@ -108,10 +156,8 @@ impl PartialEq<dyn Any> for ApproxPercentileContWithWeight
{
down_cast_any_ref(other)
.downcast_ref::<Self>()
.map(|x| {
- self.approx_percentile_cont == x.approx_percentile_cont
- && self.column_expr.eq(&x.column_expr)
- && self.weight_expr.eq(&x.weight_expr)
- && self.percentile_expr.eq(&x.percentile_expr)
+ self.signature == x.signature
Review Comment:
I don't think we need this, we can compare them with the function name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
