alamb commented on PR #10835:
URL: https://github.com/apache/datafusion/pull/10835#issuecomment-2173004020
This PR still overall doesn't seem to improve things (and maybe possibly
makes tpch_all worse)
```
group main
no-cse-copy
----- ----
-----------
physical_plan_tpcds_all 1.01 1216.3±5.36ms ?
?/sec 1.00 1204.9±5.32ms ? ?/sec
physical_plan_tpch_all 1.00 82.4±0.74ms ?
?/sec 1.01 83.5±0.68ms ? ?/sec
```
Also it clearly seems to make tpch_q1 worse, for reasons I haven't yet
figured out
```
physical_plan_tpch_q1 1.00 4.5±0.03ms ?
?/sec 1.51 6.8±0.05ms ? ?/sec
```
It may be that the Arc::unwrap --> ... --> Arc::new path is significantly
slower than just copying the Exprs for simple plans such as appear in tpch 🤔
<details><summary>Details</summary>
<p>
```
++ critcmp main no-cse-copy
group main
no-cse-copy
----- ----
-----------
logical_aggregate_with_join 1.00 1002.1±8.92µs ?
?/sec 1.00 1007.0±9.76µs ? ?/sec
logical_plan_tpcds_all 1.00 151.3±0.84ms ?
?/sec 1.00 152.0±1.10ms ? ?/sec
logical_plan_tpch_all 1.00 16.7±0.15ms ?
?/sec 1.00 16.6±0.16ms ? ?/sec
logical_select_all_from_1000 1.00 17.8±0.11ms ?
?/sec 1.01 18.0±0.14ms ? ?/sec
logical_select_one_from_700 1.00 814.5±7.90µs ?
?/sec 1.01 821.2±7.04µs ? ?/sec
logical_trivial_join_high_numbered_columns 1.00 768.4±10.32µs ?
?/sec 1.00 769.9±7.55µs ? ?/sec
logical_trivial_join_low_numbered_columns 1.00 755.9±10.60µs ?
?/sec 1.01 761.2±9.48µs ? ?/sec
physical_plan_tpcds_all 1.01 1216.3±5.36ms ?
?/sec 1.00 1204.9±5.32ms ? ?/sec
physical_plan_tpch_all 1.00 82.4±0.74ms ?
?/sec 1.01 83.5±0.68ms ? ?/sec
physical_plan_tpch_q1 1.00 4.5±0.03ms ?
?/sec 1.51 6.8±0.05ms ? ?/sec
physical_plan_tpch_q10 1.00 4.0±0.03ms ?
?/sec 1.05 4.2±0.02ms ? ?/sec
physical_plan_tpch_q11 1.02 3.5±0.03ms ?
?/sec 1.00 3.4±0.02ms ? ?/sec
physical_plan_tpch_q12 1.00 2.6±0.02ms ?
?/sec 1.05 2.8±0.03ms ? ?/sec
physical_plan_tpch_q13 1.00 1999.0±12.22µs ?
?/sec 1.02 2.0±0.01ms ? ?/sec
physical_plan_tpch_q14 1.00 2.4±0.01ms ?
?/sec 1.05 2.5±0.02ms ? ?/sec
physical_plan_tpch_q16 1.00 3.4±0.02ms ?
?/sec 1.02 3.4±0.04ms ? ?/sec
physical_plan_tpch_q17 1.06 3.2±0.06ms ?
?/sec 1.00 3.1±0.02ms ? ?/sec
physical_plan_tpch_q18 1.00 3.6±0.03ms ?
?/sec 1.01 3.6±0.02ms ? ?/sec
physical_plan_tpch_q19 1.02 5.3±0.04ms ?
?/sec 1.00 5.3±0.07ms ? ?/sec
physical_plan_tpch_q2 1.08 7.2±0.09ms ?
?/sec 1.00 6.7±0.06ms ? ?/sec
physical_plan_tpch_q20 1.05 4.1±0.03ms ?
?/sec 1.00 3.9±0.04ms ? ?/sec
physical_plan_tpch_q21 1.04 5.7±0.05ms ?
?/sec 1.00 5.5±0.05ms ? ?/sec
physical_plan_tpch_q22 1.03 3.1±0.02ms ?
?/sec 1.00 3.0±0.02ms ? ?/sec
physical_plan_tpch_q3 1.00 2.9±0.03ms ?
?/sec 1.07 3.1±0.02ms ? ?/sec
physical_plan_tpch_q4 1.02 2.2±0.02ms ?
?/sec 1.00 2.1±0.02ms ? ?/sec
physical_plan_tpch_q5 1.00 4.1±0.05ms ?
?/sec 1.02 4.2±0.04ms ? ?/sec
physical_plan_tpch_q6 1.00 1437.8±78.73µs ?
?/sec 1.04 1489.5±32.11µs ? ?/sec
physical_plan_tpch_q7 1.05 5.1±0.07ms ?
?/sec 1.00 4.9±0.04ms ? ?/sec
physical_plan_tpch_q8 1.03 6.6±0.06ms ?
?/sec 1.00 6.3±0.04ms ? ?/sec
physical_plan_tpch_q9 1.05 5.0±0.04ms ?
?/sec 1.00 4.8±0.03ms ? ?/sec
physical_select_all_from_1000 1.29 58.7±0.21ms ?
?/sec 1.00 45.6±0.15ms ? ?/sec
physical_select_one_from_700 1.04 3.6±0.02ms ?
?/sec 1.00 3.5±0.02ms ? ?/sec
```
</p>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
