crepererum commented on code in PR #10835:
URL: https://github.com/apache/datafusion/pull/10835#discussion_r1642862601
##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -172,128 +190,201 @@ impl CommonSubexprEliminate {
expr_stats,
&mut common_exprs,
)?;
+ transformed |= rewrite_exprs.transformed;
+
+ let new_input = self.rewrite(input, config)?;
+ transformed |= rewrite_exprs.transformed;
Review Comment:
shouldn't this be `new_input.transformed` or something? I don't see how
`rewritten_exprs` could have changed between this an the previous `|=`
operations 3 lines above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
