peter-toth commented on code in PR #10939: URL: https://github.com/apache/datafusion/pull/10939#discussion_r1642662746
########## datafusion/optimizer/src/common_subexpr_eliminate.rs: ########## @@ -84,11 +84,11 @@ type IdArray = Vec<(usize, Identifier)>; /// - The number of occurrences and /// - The DataType /// of an expression. -type ExprStats = HashMap<Identifier, (usize, DataType)>; +type ExprStats = HashMap<Identifier, usize>; /// A map that contains the common expressions extracted during the second, rewriting /// traversal. Review Comment: Thanks! Fixed in https://github.com/apache/datafusion/pull/10939/commits/be2e5606cbe34b9d6c0b3d8cad56499a7c5ef96e together with `ExprStats` docstring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
