waynexia commented on PR #10939: URL: https://github.com/apache/datafusion/pull/10939#issuecomment-2174893021
Looking great! The CSE alias has changed many times, I think it's much closer to its final form now (I've skimmed #10473, and it also looks very :cool:!) One thing I'd like to discuss is the prefix name. Unlike (https://github.com/apache/datafusion/pull/10868#issuecomment-2171754117) `scalar`, `cse` is an abbreviation and I'm not sure if it's that general and most users can figure out what it means. How about expanding it to something like `common_expr` to avoid potential confusion 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
