parthchandra commented on code in PR #577: URL: https://github.com/apache/datafusion-comet/pull/577#discussion_r1643577459
########## spark/inspections/CometTPCHQueriesList-results.txt: ########## @@ -1,133 +1,133 @@ -Query: q1 TPCH Snappy. Comet Exec: Enabled (CometHashAggregate, CometProject) +Query: q1 TPCH Snappy. Comet Exec: Enabled (CometHashAggregate, CometFilter, CometProject) Query: q1 TPCH Snappy: ExplainInfo: Comet shuffle is not enabled: spark.sql.adaptive.coalescePartitions.enabled is enabled and spark.comet.shuffle.enforceMode.enabled is not enabled Query: q2 TPCH Snappy. Comet Exec: Enabled (CometFilter, CometProject) Query: q2 TPCH Snappy: ExplainInfo: -BroadcastExchange is not supported +BroadcastHashJoin is not enabled because not all child plans are native Review Comment: The information is, in fact, in the nodes and it is collected (and de-deuped) later. It's just not printed out in a tree view. I've added the additional information for nodes where we were explicitly printing the 'not all children are native' message. For most cases where a node is not native because the children are not native, we don't have any information because in the flattened view it is rather uninformative. I can add the nested view as an additional interface in `ExtendedExplainInfo` and can print that in the queries list output based on a flag. At some later date if we no longer find the aggregated use case useful, we can switch the flag so the same output will show up in Spark UI as well. Over time I expect the information we add in explain info will keep changing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
