andygrove commented on code in PR #577:
URL: https://github.com/apache/datafusion-comet/pull/577#discussion_r1643590899
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -221,6 +221,16 @@ class CometSparkSessionExtensions
private def isCometNative(op: SparkPlan): Boolean =
op.isInstanceOf[CometNativeExec]
+ private def explainChildNotNative(op: SparkPlan): String = {
+ var nonNatives: Seq[String] = Seq()
+ op.children.foreach(plan => {
+ if (!isCometNative(plan)) {
+ nonNatives = nonNatives :+ plan.nodeName
+ }
+ })
Review Comment:
nit: this can be simplified with a functional approach:
```suggestion
val nonNatives: Seq[String] =
op.children.filterNot(isCometNative).map(_.nodeName)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
