Blizzara commented on code in PR #11049:
URL: https://github.com/apache/datafusion/pull/11049#discussion_r1650475631
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -317,16 +317,27 @@ fn rename_expressions(
.into_iter()
Review Comment:
Sure, added some docs in
https://github.com/apache/datafusion/pull/11049/commits/87829ece5f0473c001a56ecd6355b95436751fe1
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -846,6 +861,24 @@ pub async fn from_substrait_rel(
}
}
+fn requalify_sides_if_needed(
Review Comment:
Added a short version in
https://github.com/apache/datafusion/pull/11049/commits/87829ece5f0473c001a56ecd6355b95436751fe1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
