Blizzara commented on PR #11049: URL: https://github.com/apache/datafusion/pull/11049#issuecomment-2185795038
Thanks for the review @alamb - I added some docs in https://github.com/apache/datafusion/pull/11049/commits/87829ece5f0473c001a56ecd6355b95436751fe1, and also cleaned/improved stuff a bit. However I also realized this approach falls short form providing full guarantee of uniqueness either, since the left or right side _itself_ may contain duplicate names with different qualifiers, which then would turn into full duplicates once the side gets aliased. Unfortunately I don't see a way around that currently other than adding a lot more complexity into the renaming to basically qualify each column separately or something. (Or switching DataFusion to use something else than column name to refer to columns, e.g. position or some unique expr ID, but that's probably quite a big change 😅 ) Anyways I don't expect that to be very common case, so maybe we can go with just this for now and then improve on it later if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
