jayzhan211 commented on code in PR #11093:
URL: https://github.com/apache/datafusion/pull/11093#discussion_r1650718130
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -314,11 +322,17 @@ impl ExprSchemable for Expr {
}
}
Expr::Cast(Cast { expr, .. }) => expr.nullable(input_schema),
+ Expr::AggregateFunction(AggregateFunction { func_def, .. }) => {
+ match func_def {
+ AggregateFunctionDefinition::BuiltIn(fun) =>
fun.nullable(),
+ // TODO: UDF should be able to customize nullability
Review Comment:
I'm not sure about that we need to customize nullability, can we get the
nullabiity based on expression in the function?
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -314,11 +322,17 @@ impl ExprSchemable for Expr {
}
}
Expr::Cast(Cast { expr, .. }) => expr.nullable(input_schema),
+ Expr::AggregateFunction(AggregateFunction { func_def, .. }) => {
+ match func_def {
+ AggregateFunctionDefinition::BuiltIn(fun) =>
fun.nullable(),
+ // TODO: UDF should be able to customize nullability
Review Comment:
I'm not sure about whether we need to customize nullability, can we get the
nullabiity based on expression in the function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
