findepi commented on PR #11225: URL: https://github.com/apache/datafusion/pull/11225#issuecomment-2204481535
> For things like csv reading and dataframe aggregation, once you have the code in the IDE, perhaps those examples would be better directly in the doc as run doc examples Might be. I think it's good reasoning to table https://github.com/apache/datafusion/pull/11219 for now, I closed that PR. Thanks for feedback! What do you think about this PR? As long as we have directly runnable examples, we should ensure they work. CI and README don't agree on the current working directory. We can sync CI and README. Or we can assume cwd doesn't matter (and have CI prove that), which sounds more complex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
