findepi commented on code in PR #11225: URL: https://github.com/apache/datafusion/pull/11225#discussion_r1665180701
########## datafusion-examples/README.md: ########## @@ -35,6 +35,9 @@ cd datafusion # Download test data git submodule update --init Review Comment: thanks @alamb for testing this. let me quote the commit message, maybe it explains my reasoning better: ``` ... Some examples are runnable from any place (e.g. `csv_sql`), but some expect a specific working directory (e.g. `regexp`). Running from `datafusion-examples/examples` is tested on CI so guaranteed to work, let's put this path in the README. ... ``` > It does also work in datafusion-examples/examples/ but cding into that directory seems unecessary i agree. It happened to be necessary for the first example i tried to run. maybe i was just unlucky per the commit message ``` ... As a follow-up, we should look what it would take to make examples runnable directly from an IDE such as RustRover. ``` -- I also am against cd-ing into directory as unnecessary and also want the examples to be runnable from an IDE. If we want this to be the case, this validated by the CI scripts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
