efredine opened a new pull request, #11236: URL: https://github.com/apache/datafusion/pull/11236
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #11235. ## Rationale for this change There were several tests where we missed changing `Check::RowGroup` to `Check::Both`. ## What changes are included in this PR? Changes most remaining tests in https://github.com/apache/datafusion/blob/3421b52605b00cd2e5a6498ea210cce196a19496/datafusion/core/tests/parquet/arrow_statistics.rs to `Check::Both`. The only two remaining tests are the one still in flight in https://github.com/apache/datafusion/pull/11200 and the one for nested Struct which hasn't been implemented yet. However, note that there were two failing tests: https://github.com/apache/datafusion/blob/3421b52605b00cd2e5a6498ea210cce196a19496/datafusion/core/tests/parquet/arrow_statistics.rs#L1474 and https://github.com/apache/datafusion/blob/3421b52605b00cd2e5a6498ea210cce196a19496/datafusion/core/tests/parquet/arrow_statistics.rs#L1485 I "fixed" these tests from changing from `u32::try_from(x).ok` to `Some(x as u32)` and similar for u64. I did this because I noticed its what the existing Row Group statistics tests are doing as well. But I'm unsure whether this is the right thing to do? ## Are these changes tested? Yes ## Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
