alamb commented on code in PR #11236: URL: https://github.com/apache/datafusion/pull/11236#discussion_r1664808021
########## datafusion/core/src/datasource/physical_plan/parquet/statistics.rs: ########## @@ -766,7 +766,7 @@ macro_rules! get_data_page_statistics { [<$stat_type_prefix Int32DataPageStatsIterator>]::new($iterator) .map(|x| { x.into_iter().filter_map(|x| { Review Comment: I think the parquet physical types are always signed (because of its heavy java influence) so when storing unsigned values in arrow they need to be cast using `as` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org