mustafasrepo commented on code in PR #11196:
URL: https://github.com/apache/datafusion/pull/11196#discussion_r1663551652
##########
datafusion/physical-expr/src/equivalence/properties.rs:
##########
@@ -173,6 +174,12 @@ impl EquivalenceProperties {
self.oeq_class.clear();
}
+ /// Removes constant expressions that may change across partitions.
+ /// This method should be used when different partitions are fused.
Review Comment:
What I mean is data from multiple partitions ends up in another partition
(operators that does this `CoalescePartitionsExec`, `SortPreservingMergeExec`,
`InterleaveExec`, `RepartitionExec`). I changed to term to "merge" in 747b69bf.
However, If you have other suggestions which communicates the intent in this
context better (maybe more common vocabulary in literature). I can update with
that term.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
