mustafasrepo commented on code in PR #11196:
URL: https://github.com/apache/datafusion/pull/11196#discussion_r1663596920
##########
datafusion/physical-expr/src/equivalence/properties.rs:
##########
@@ -781,24 +814,30 @@ impl EquivalenceProperties {
/// # Returns
///
/// Returns a `Vec<Arc<dyn PhysicalExpr>>` containing the projected
constants.
- fn projected_constants(
- &self,
- mapping: &ProjectionMapping,
- ) -> Vec<Arc<dyn PhysicalExpr>> {
+ fn projected_constants(&self, mapping: &ProjectionMapping) ->
Vec<ConstExpr> {
// First, project existing constants. For example, assume that `a + b`
// is known to be constant. If the projection were `a as a_new`, `b as
b_new`,
// then we would project constant `a + b` as `a_new + b_new`.
let mut projected_constants = self
.constants
.iter()
- .flat_map(|expr| self.eq_group.project_expr(mapping, expr))
+ .flat_map(|const_expr| {
+ self.eq_group
Review Comment:
Changed in 747b69bf7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
