dharanad commented on code in PR #11263: URL: https://github.com/apache/datafusion/pull/11263#discussion_r1665461086
########## datafusion/core/src/execution/session_state.rs: ########## @@ -967,14 +967,19 @@ impl SessionState { let field_access_planner = Arc::new(functions_array::planner::FieldAccessPlanner) as _; - query + query = query .with_user_defined_planner(array_planner) .with_user_defined_planner(field_access_planner) } - #[cfg(not(feature = "array_expressions"))] + #[cfg(feature = "unicode_expressions")] { - query + let position_planner = + Arc::new(functions::unicode::planner::PositionPlanner::default()) as _; + + query = query.with_user_defined_planner(position_planner); } + + query Review Comment: As commented in https://github.com/apache/datafusion/pull/11243 let move this to constructor of `SessionState` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org