xinlifoobar commented on code in PR #11263:
URL: https://github.com/apache/datafusion/pull/11263#discussion_r1666300246


##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -170,6 +170,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
         schema: &DFSchema,
         planner_context: &mut PlannerContext,
     ) -> Result<Expr> {
+        let sql_not_moved = sql.clone();

Review Comment:
   This isn't good. We may want something like 
https://github.com/VitWW/rfcs/blob/partial_types3/text/0000-partial_types.md
   
   to implement partial move...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to