viirya commented on code in PR #613:
URL: https://github.com/apache/datafusion-comet/pull/613#discussion_r1666331623


##########
.github/workflows/benchmark.yml:
##########
@@ -141,7 +141,7 @@ jobs:
           SPARK_HOME=`pwd` SPARK_TPCDS_DATA=`pwd`/tpcds-sf-1 ./mvnw -B 
-Prelease -Dsuites=org.apache.spark.sql.CometTPCDSQuerySuite test
         env:
           SPARK_TPCDS_JOIN_CONF: |
-            spark.sql.autoBroadcastJoinThreshold=-1
+            spark.sql.autoBroadcastJoinThreshold=-2 # Set to -2 to force Spark 
to sort the results

Review Comment:
   Spark `TPCDSQueryTestSuite` checks if `spark.sql.autoBroadcastJoinThreshold` 
is -1 to decide whether to sort returned results.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to