andygrove commented on code in PR #613:
URL: https://github.com/apache/datafusion-comet/pull/613#discussion_r1672476021
##########
spark/src/test/scala/org/apache/spark/sql/CometTPCDSQuerySuite.scala:
##########
@@ -157,9 +191,11 @@ class CometTPCDSQuerySuite
conf.set(CometConf.COMET_EXEC_ENABLED.key, "true")
conf.set(CometConf.COMET_EXEC_ALL_OPERATOR_ENABLED.key, "true")
conf.set(CometConf.COMET_EXEC_SHUFFLE_ENABLED.key, "true")
- conf.set(CometConf.COMET_MEMORY_OVERHEAD.key, "20g")
+ conf.set(CometConf.COMET_MEMORY_OVERHEAD.key, "15g")
+ conf.set(CometConf.COMET_SHUFFLE_ENFORCE_MODE_ENABLED.key, "true")
+ conf.set("spark.sql.adaptive.coalescePartitions.enabled", "true")
Review Comment:
Before we can close https://github.com/apache/datafusion-comet/issues/387 we
should either change the default for `COMET_SHUFFLE_ENFORCE_MODE_ENABLED` or
remove it completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
