xinlifoobar commented on issue #11207:
URL: https://github.com/apache/datafusion/issues/11207#issuecomment-2210845458
> Given #11220 and #11243, those are very similar APIs with UDF plans. I am
trying to draft an API, e.g.,
>
> ```
> // Plan the user defined function, returns origin expression arguments
if not possible
> fn plan_udf(
> &self,
> _sql: &sqlparser::ast::Expr,
> args: Vec<Expr>,
> ) -> Result<PlannerResult<Vec<Expr>>> {
> Ok(PlannerResult::Original(args))
> }
> ```
>
> to uniform the usages.
>
> I have created a draft PR #11263 to discuss this. The flaw here is that
the parameter `sql` is partially borrowed and has to be cloned at the very
beginning. Maybe we should consider using references if possible.
Eventually, I made this #11263, please let me know your thoughts. Thanks :)
CC @jayzhan211 @dharanad @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
