jayzhan211 commented on PR #11247:
URL: https://github.com/apache/datafusion/pull/11247#issuecomment-2210846681

   ```
   Benchmark tpch_sf10.json
   --------------------
   ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
   ┃ Query        ┃      main ┃ add_short_circuit ┃        Change ┃
   ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
   │ QQuery 1     │ 1016.92ms │          818.68ms │ +1.24x faster │
   │ QQuery 2     │  146.80ms │          131.71ms │ +1.11x faster │
   │ QQuery 3     │  445.80ms │          417.92ms │ +1.07x faster │
   │ QQuery 4     │  228.00ms │          212.54ms │ +1.07x faster │
   │ QQuery 5     │  616.29ms │          562.94ms │ +1.09x faster │
   │ QQuery 6     │  193.28ms │          188.68ms │     no change │
   │ QQuery 7     │  806.95ms │          853.22ms │  1.06x slower │
   │ QQuery 8     │  582.18ms │          636.72ms │  1.09x slower │
   │ QQuery 9     │  926.48ms │          974.76ms │  1.05x slower │
   │ QQuery 10    │  632.74ms │          621.95ms │     no change │
   │ QQuery 11    │   83.91ms │           80.06ms │     no change │
   │ QQuery 12    │  318.26ms │          322.94ms │     no change │
   │ QQuery 13    │  495.16ms │          508.65ms │     no change │
   │ QQuery 14    │  261.28ms │          271.91ms │     no change │
   │ QQuery 15    │  386.88ms │          392.05ms │     no change │
   │ QQuery 16    │  124.54ms │          121.21ms │     no change │
   │ QQuery 17    │ 1301.28ms │         1304.97ms │     no change │
   │ QQuery 18    │ 1356.90ms │         1364.60ms │     no change │
   │ QQuery 19    │  509.38ms │          523.05ms │     no change │
   │ QQuery 20    │  504.72ms │          501.61ms │     no change │
   │ QQuery 21    │ 1033.29ms │         1041.01ms │     no change │
   │ QQuery 22    │  136.02ms │          134.02ms │     no change │
   └──────────────┴───────────┴───────────────────┴───────────────┘
   ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
   ┃ Benchmark Summary                ┃            ┃
   ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
   │ Total Time (main)                │ 12107.07ms │
   │ Total Time (add_short_circuit)   │ 11985.18ms │
   │ Average Time (main)              │   550.32ms │
   │ Average Time (add_short_circuit) │   544.78ms │
   │ Queries Faster                   │          5 │
   │ Queries Slower                   │          3 │
   │ Queries with No Change           │         14 │
   └──────────────────────────────────┴────────────┘
   ```
   
   I'm quite surprise that the change is slower for some queries


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to