Blizzara commented on code in PR #11278:
URL: https://github.com/apache/datafusion/pull/11278#discussion_r1667027578


##########
datafusion/substrait/tests/testdata/data.csv:
##########
@@ -1,3 +1,3 @@
 a,b,c,d,e,f
-1,2.0,2020-01-01,false,4294967296,'a'
-3,4.5,2020-01-01,true,2147483648,'b'
\ No newline at end of file
+1,2.0,2020-01-01,false,4294967295,'a'

Review Comment:
   The old value was 1 larger than what fits into uint64, so executing against 
this file failed.
   
   I didn’t see any reason why the over-large value would be useful, so this 
brings it down into the range that actually fits into uint64



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to