Blizzara commented on code in PR #11278: URL: https://github.com/apache/datafusion/pull/11278#discussion_r1667159836
########## datafusion/substrait/tests/testdata/data.csv: ########## @@ -1,3 +1,3 @@ a,b,c,d,e,f -1,2.0,2020-01-01,false,4294967296,'a' -3,4.5,2020-01-01,true,2147483648,'b' \ No newline at end of file +1,2.0,2020-01-01,false,4294967295,'a' Review Comment: Ah yes, I misremembered. It’s int32 as specified here https://github.com/apache/datafusion/blob/2aa57386c12e57d2fe865360f3eead358cc237f7/datafusion/substrait/tests/cases/roundtrip_logical_plan.rs#L1125. Maybe the original number at some point had some meaning to test the int32/int64 difference, but I don’t see what purpose it’s serve in the substrait roundtrip tests 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
