viirya commented on code in PR #11276:
URL: https://github.com/apache/datafusion/pull/11276#discussion_r1667615735
##########
datafusion/physical-plan/src/joins/utils.rs:
##########
@@ -1411,6 +1424,63 @@ where
.collect::<PrimitiveArray<T>>()
}
+/// Appends probe indices in order by considering the given build indices.
+///
+/// This function constructs new build and probe indices by iterating through
+/// the provided indices, and appends any missing values between previous and
+/// current probe index with a corresponding null build index. It handles
various
+/// edge cases and returns an error if either index is `None`.
Review Comment:
It doesn't return `Result`.
```suggestion
/// current probe index with a corresponding null build index.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
