ozankabak commented on code in PR #11276: URL: https://github.com/apache/datafusion/pull/11276#discussion_r1667736330
########## datafusion/physical-plan/src/joins/utils.rs: ########## @@ -1332,24 +1339,30 @@ pub(crate) fn adjust_indices_by_join_type( pub(crate) fn append_right_indices( Review Comment: The docstring for this function is out of date, let's update ########## datafusion/sqllogictest/test_files/joins.slt: ########## @@ -3813,3 +3813,58 @@ logical_plan 01)SubqueryAlias: b 02)--Projection: Int64(1) AS a 03)----EmptyRelation + + +statement ok +set datafusion.execution.target_partitions = 1; + +statement ok +set datafusion.explain.logical_plan_only = false; + +# Right Hash Joins preserve the right ordering +query IIII +SELECT * FROM ( + SELECT 1 as a, 1 as b +) as lhs RIGHT JOIN ( Review Comment: @berkaysynnada, let's update the test to address -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
