Blizzara commented on issue #630: URL: https://github.com/apache/datafusion-comet/issues/630#issuecomment-2213760276
> I created #637 so that we can start splitting code out into separate crates. Nice, glad to hear this resonates and thanks! > I also started looking at what would be involved in creating a `datafusion-comet-spark-expr` crate, and the first issue I ran into is that our `CometError` type has dependencies on the JNI crate, and this doesn't seem ideal for pure Rust downstream projects that just want to re-use the expressions. Perhaps we'll need a separate error type that the new crate can use and that we can convert into a CometError for the Comet/Spark integration. Hmm, would it make sense to use just DataFusionError for those? I think for a 3rd party user (like me) it would be fine, and just easier if I only need to handle one type of error coming from DF + these expressions, but dunno if Comet internally needs something else from the errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
