xinlifoobar commented on PR #11330: URL: https://github.com/apache/datafusion/pull/11330#issuecomment-2213809531
> Thanks @xinlifoobar working on this issue. > > What I suggest is that we can let people to define their own normalizations. Rather than directing all values to lowercase, people can declare their own normalization methods for specific option keys. If we choose to do that in this PR, I believe the normalization process should be done during the assignment of table options. The APIs that could be used in the `datafusion-sql` crate are limited. Do you think it is a good idea to add a method, e.g., `get_options_normalized_function` a good idea? https://github.com/apache/datafusion/blob/2f02c43b6283472c7c620c68819050128a7e8544/datafusion/expr/src/planner.rs#L33-L83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
