goldmedal commented on PR #11361: URL: https://github.com/apache/datafusion/pull/11361#issuecomment-2220709681
> For `make_map(k1, v1, k2, v2...)`, ideally we can arrange the order of args and call `map([k1, k2..], [v1, v2])`. I think we can arrange it in ExprPlanner, so we can have only one function `map` instead of two. Thanks @jayzhan211. Sounds great. Curiously, what's the benefit of moving to `ExprPlanner`? I'm not sure, but I think it just moves the cost of aggregating column values to `ExprPlanner`, right? Or is it possible to get better performance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org