goldmedal commented on PR #11361: URL: https://github.com/apache/datafusion/pull/11361#issuecomment-2221830803
> So my suggestion is: > > 1. File a separate datafusion ticket about the fact that `named_struct` allows repeated field names > 2. either file a new ticket (or Update this PR) to enforce the uniqueness of map key name for the `map`/`make_map` function Thanks @alamb. I prefer to file new tickets for them. > Some initial thoughts on things left to do: > > 1. document `map`/`make_map` in the documentation. We can do this as a follow on PR: https://datafusion.apache.org/user-guide/sql/scalar_functions.html#struct-functions > 2. Support arrays (not just scalars) > 3. Decide if we want to have `make_map` follow `named_struct` or if it would be better to have something more like what duckdb does > I'll address the comments for the code today, and then file the following issues for it. (maybe after merging?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
