viirya commented on code in PR #613:
URL: https://github.com/apache/datafusion-comet/pull/613#discussion_r1672512250
##########
spark/src/test/scala/org/apache/spark/sql/CometTPCDSQuerySuite.scala:
##########
@@ -112,7 +108,9 @@ class CometTPCDSQuerySuite
"q69",
"q70",
"q71",
- "q72",
+ // TODO: unknown failure (seems memory usage over Github action
runner) in CI with q72 in
+ // https://github.com/apache/datafusion-comet/pull/613.
+ // "q72",
Review Comment:
> The purpose of q72 is to test vendors join reordering rules, and that
isn't really very relevant to Spark or Comet since Spark queries typically
don't have access to statistics.
Btw, Spark has the capacity to do join reordering if statistics are
available but it relies on enabling CBO features which are disabled by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
