dharanad commented on PR #616: URL: https://github.com/apache/datafusion-comet/pull/616#issuecomment-2221940686
> @planga82 Please see [apache/datafusion# v](https://github.com/apache/datafusion/pull/11400) that I just created against DataFusion, which possibly gives us most of what we need, although the same principals could be applied directly in Comet. > > They key change was adding a `fail_on_overflow` config in `BinaryExpr` and then choosing to call either `add` or `add_wrapped` depending on that value. This is amazing, thanks for https://github.com/apache/datafusion/pull/11400 . I have considered this idea, but I wasn't sure how to suggest this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
