crepererum opened a new pull request, #11411:
URL: https://github.com/apache/datafusion/pull/11411

   ## Which issue does this PR close?
   Amends #11394 (sorry, I should have reviewed that).
   
   ## Rationale for this change
   While reporting "not implemented" for "multiple statements" seems 
reasonable, I think the user should get a plan error (which roughly translates 
to "invalid argument") if they don't provide any statement. I don't see any 
reasonable way to support "no statement" ever, hence "not implemented" seems 
like a wrong promise.
   
   ## What changes are included in this PR?
   The user now gets a plan error instead of "no implemented" if no statement 
was provided.
   
   ## Are these changes tested?
   Adjusted existing test.
   
   ## Are there any user-facing changes?
   Improved error type. Esp. if the user converts that error type into a 
gRPG/HTTP error (e.g. IOx does this) then you can expect a more appropriate 
outcome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to