adriangb commented on PR #20060: URL: https://github.com/apache/datafusion/pull/20060#issuecomment-3816896758
This sounds good to me. We’ve made breaking changes to this struct before by moving around fields that would have been non breaking if they weren’t public, and as far as I can tell it was somewhat accidental to make them pub instead of pub(crate) in the first place. Could you do a quick GitHub search to see if anyone is using these fields? Could check Delta, Comet, etc. Assuming we don’t find any usage in the wild, how do we inform users? I think we should at least say that any requests to make these fields public we are happy to honor, add public methods for, etc. Basically if you were using this sorry about the breakage happy to revert. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
