adriangb commented on PR #20060:
URL: https://github.com/apache/datafusion/pull/20060#issuecomment-3817601507

   Ah you're right! Then this is a meaningless exercise: `pub` fields on a 
`pub(super)` struct are not actually part of the public API / changing them is 
not a breaking change for users.
   
   Thank you for following up @xudong963, it seems I was wrong with my original 
comment and it was a waste of time. Sorry about that...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to