mbutrovich commented on code in PR #3322:
URL: https://github.com/apache/datafusion-comet/pull/3322#discussion_r2746950965
##########
spark/src/main/scala/org/apache/comet/serde/operator/CometNativeScan.scala:
##########
@@ -77,6 +78,18 @@ object CometNativeScan extends
CometOperatorSerde[CometScanExec] with Logging {
withInfo(scanExec, "Full native scan disabled because ignoreMissingFiles
enabled")
}
+ if (scanExec.fileConstantMetadataColumns.nonEmpty) {
+ withInfo(scanExec, "Native DataFusion scan does not support metadata
columns")
+ }
+
+ if (scanExec.bucketedScan) {
+ withInfo(scanExec, "Native DataFusion scan does not support bucketed
scans")
Review Comment:
Yes it does, I think we just fail the Spark SQL test for not formatting the
explain output in the same way. I'm confused how this PR is passing the test
that #2888 added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
