zhuqi-lucas commented on code in PR #20043:
URL: https://github.com/apache/datafusion/pull/20043#discussion_r2749144226
##########
datafusion/datasource/src/file.rs:
##########
@@ -189,7 +189,29 @@ pub trait FileSource: Send + Sync {
/// * `Inexact` - Created a source optimized for ordering (e.g., reversed
row groups) but not perfectly sorted
/// * `Unsupported` - Cannot optimize for this ordering
///
- /// Default implementation returns `Unsupported`.
+ /// # Deprecation / migration notes
+ /// - [`Self::try_reverse_output`] was renamed to this method and
deprecated since `52.0.0`.
Review Comment:
Same here, should be 53.0.0?
##########
datafusion/datasource/src/file.rs:
##########
@@ -189,7 +189,29 @@ pub trait FileSource: Send + Sync {
/// * `Inexact` - Created a source optimized for ordering (e.g., reversed
row groups) but not perfectly sorted
/// * `Unsupported` - Cannot optimize for this ordering
///
- /// Default implementation returns `Unsupported`.
+ /// # Deprecation / migration notes
+ /// - [`Self::try_reverse_output`] was renamed to this method and
deprecated since `52.0.0`.
+ /// Per DataFusion's deprecation guidelines, it will be removed in
`58.0.0` or later
+ /// (6 major versions or 6 months, whichever is longer).
+ /// - New implementations should override [`Self::try_pushdown_sort`]
directly.
+ /// - For backwards compatibility, the default implementation of
+ /// [`Self::try_pushdown_sort`] delegates to the deprecated
+ /// [`Self::try_reverse_output`] until it is removed. After that point,
the
+ /// default implementation will return
[`SortOrderPushdownResult::Unsupported`].
+ fn try_pushdown_sort(
+ &self,
+ order: &[PhysicalSortExpr],
+ eq_properties: &EquivalenceProperties,
+ ) -> Result<SortOrderPushdownResult<Arc<dyn FileSource>>> {
+ #[expect(deprecated)]
+ self.try_reverse_output(order, eq_properties)
+ }
+
+ /// Deprecated: Renamed to [`Self::try_pushdown_sort`].
+ #[deprecated(
+ since = "52.0.0",
Review Comment:
Should be 53.0.0 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
