askalt commented on code in PR #20009:
URL: https://github.com/apache/datafusion/pull/20009#discussion_r2753641941
##########
datafusion/physical-plan/src/joins/symmetric_hash_join.rs:
##########
@@ -647,6 +650,97 @@ impl ExecutionPlan for SymmetricHashJoinExec {
)
.map(|e| Some(Arc::new(e) as _))
}
+
+ fn physical_expressions<'a>(
+ &'a self,
+ ) -> Option<Box<dyn Iterator<Item = Arc<dyn PhysicalExpr>> + 'a>> {
+ let left_sort_iter = self
Review Comment:
We can see the following in the mentioned test explain:
```
HashJoinExec: mode=CollectLeft, join_type=Inner, on=[(id@0, t1.id +
$1@2)], projection=[age@1, name@3]",
```
It seems there is a placeholder in the `.on`. How it becomes resolved, if we
do not provide `.on` in `physical_expr(...)`? I do not think it's not, just
curious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
