comphead commented on code in PR #20112:
URL: https://github.com/apache/datafusion/pull/20112#discussion_r2756078436
##########
datafusion/functions/src/string/to_hex.rs:
##########
@@ -78,6 +77,14 @@ where
Ok(Arc::new(result) as ArrayRef)
}
+#[inline]
+fn to_hex_scalar<T: ToHex>(value: T) -> String {
+ let mut hex_buffer = [0u8; 16];
Review Comment:
we prob can make it reusable buffer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
