Jefffrey commented on code in PR #20112:
URL: https://github.com/apache/datafusion/pull/20112#discussion_r2761911367
##########
datafusion/functions/src/string/to_hex.rs:
##########
@@ -78,6 +77,14 @@ where
Ok(Arc::new(result) as ArrayRef)
}
+#[inline]
+fn to_hex_scalar<T: ToHex>(value: T) -> String {
+ let mut hex_buffer = [0u8; 16];
Review Comment:
This function should be called only once per invocation so I don't think we
need to change this to reuse a buffer. Looks like the array path already has a
reusable buffer too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
