alamb commented on code in PR #20070:
URL: https://github.com/apache/datafusion/pull/20070#discussion_r2761138300
##########
datafusion/sqllogictest/test_files/union_function.slt:
##########
@@ -32,13 +32,13 @@ select union_column, union_extract(union_column, 'int')
from union_table;
query error DataFusion error: Execution error: field bool not found on union
select union_extract(union_column, 'bool') from union_table;
-query error DataFusion error: Error during planning: 'union_extract' does not
support zero arguments
+query error Failed to coerce function call 'union_extract\(\)'
Review Comment:
the old message about not supporting zero arguments seems like it was nicer
##########
datafusion/sqllogictest/test_files/scalar.slt:
##########
@@ -2069,7 +2069,7 @@ select position('' in '')
----
1
-query error DataFusion error: Error during planning: Function 'strpos'
requires TypeSignatureClass::Native\(LogicalType\(Native\(String\), String\)\),
but received Int64 \(DataType: Int64\)
+query error Failed to coerce function call 'strpos\(Int64, Int64\)'
Review Comment:
it feels like the previous messages were better even if they were more
verbose, as they at least try to explain to a user what was expected. I do
admit that the `TypeSignatureClass::Native<...` is not very user friendly,
however
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
