sdf-jkl commented on PR #20099: URL: https://github.com/apache/datafusion/pull/20099#issuecomment-3844304638
@alamb in https://github.com/apache/datafusion/pull/20051#issuecomment-3843460653 you mention that it's better to keep slt tests in `floor.rs` instead of `floor_preimage.rs`, but the original `floor` slt tests are in a different file for multiple scalar functions: https://github.com/apache/datafusion/blob/b80bf2ca8ef74900fee96a1cc169bdedf53b36fc/datafusion/sqllogictest/test_files/scalar.slt#L484 Should we move all the new slt tests there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
