andygrove commented on code in PR #3383:
URL: https://github.com/apache/datafusion-comet/pull/3383#discussion_r2764245105
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -989,8 +989,7 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
castTest(generateDates(), DataTypes.StringType)
}
- ignore("cast DateType to TimestampType") {
- // Arrow error: Cast error: Casting from Date32 to Timestamp(Microsecond,
Some("UTC")) not supported
+ test("cast DateType to TimestampType") {
castTest(generateDates(), DataTypes.TimestampType)
Review Comment:
`generateDates` only returns 3 values, so we don't have good test coverage
here. Could you add some tests specifically for DST transition dates, like
dates around 2023-03-12 or 2023-11-05 for US timezones, with different session
timezones configured. This would help verify the timezone conversion logic
matches Spark's behavior for those edge cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
